Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix incorrect delete in MXExecutorReshape exception handling (#13376) #13824

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

safrooze
Copy link
Contributor

@safrooze safrooze commented Jan 9, 2019

Cherrypicking #13376 to 1.4.x branch.

…13376)

* Fix bad delete.

Delete the pointed-to handle on cleanup, not the location of the handle itself. Also don't delete it if we didn't set it in the first place.

* Remove unusued 'exec' var from MXExecutorBindEX.
@safrooze safrooze requested a review from anirudh2290 as a code owner January 9, 2019 22:32
@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 10, 2019
@safrooze
Copy link
Contributor Author

@eric-haibin-lin Can you please review/merge so it is included in 1.4.0 release?

@safrooze
Copy link
Contributor Author

@KellenSunderland

@eric-haibin-lin eric-haibin-lin merged commit 84beaf1 into apache:v1.4.x Jan 11, 2019
lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Feb 18, 2019
…13376) (apache#13824)

* Fix bad delete.

Delete the pointed-to handle on cleanup, not the location of the handle itself. Also don't delete it if we didn't set it in the first place.

* Remove unusued 'exec' var from MXExecutorBindEX.
@pinaraws
Copy link

Merged
@mxnet-label-bot remove [pr-awaiting-review]

@marcoabreu marcoabreu removed the pr-awaiting-review PR is waiting for code review label Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants